💥 Make service FKs in API group config models not nullable #4916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Catalogi and Documents API are optional, but the objecttypes and objects API services are not. These fields were null because the model was originally a django-solo singleton model which must be able to be created without any services existing prior. A check script is added to prevent being stuck in half-migrated upgrades.
Left-overs from a django-solo model too (see previous commit), these fields really cannot be empty to do anything useful. This properly sets up the required constraints at the database level and removes confusion in the application code.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4916 +/- ##
==========================================
- Coverage 96.57% 96.57% -0.01%
==========================================
Files 757 757
Lines 25750 25748 -2
Branches 3383 3377 -6
==========================================
- Hits 24869 24867 -2
Misses 616 616
Partials 265 265 ☔ View full report in Codecov by Sentry. |
sergei-maertens
changed the title
stevenbal
approved these changes
Dec 17, 2024
| headers=("API group type", "ID", "Name", "Problem"), | ||
| ) | ||
| ) | ||
| return True |
There was a problem hiding this comment.
Not a major thing, but does this have to return something?
There was a problem hiding this comment.
yeah, the return value is checked by the upgrade check which blocks migrating if problems are detected! See
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #3283
Changes
null=Falsefor the non-optional fields.Checklist
Check off the items that are completed or not relevant.
Impact on features
Release management
I have updated the translations assets (you do NOT need to provide translations)
./bin/makemessages_js.sh./bin/compilemessages_js.shDockerfile/scripts
./binfolderCommit hygiene